Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): re-publish docs on python unleash and generic integrations #12300

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jan 10, 2025

These docs were originally approved and published, but reverted in #12296 since the integrations aren't released, and won't be for at least a couple days.

This PR re-publishes them and

Closes https://github.com/getsentry/team-replay/issues/516

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:21am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 9:21am

Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Changes will increase total bundle size by 261 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 75 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 367.09kB 342 bytes (0.09%) ⬆️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

@@ -0,0 +1,49 @@
---
title: Generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the title a little more descriptive here? Like 'Generic Feature Flags' or something like that? Same with the page title for 'Unleash', maybe 'Feature Flags using Unleash'?

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move generic integration documentation to platform/<language>/feature-flags since the generic integration is going away. Ref: getsentry/sentry-python#3917

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some smaller changes to push this over the finish line.

@antonpirker antonpirker merged commit 4b81e30 into master Jan 14, 2025
13 checks passed
@antonpirker antonpirker deleted the revert-12296-aliu/unpublish-unleash branch January 14, 2025 09:27
---

<PlatformContent includePath="feature-flags/prerelease-alert" />

A feature flagging integration allows you to manually track feature flag evaluations through an API. These evaluations are collected in memory, and in the event an error occurs, sent to Sentry for review and analysis.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A feature flagging integration allows you to manually track feature flag evaluations through an API.

This isn't correct, the integrations automatically hook into the 3rd party SDK's evaluations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see this was copied from the integrations/feature-flags/ page, will correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants